-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error handling, documentation and tests of itertools
#548
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for including the documentation here.
I just have a few remarks regarding the runtime of itemize
when keep_ends=True
is specified. The runtime is only depending on the value of keep_ends
if sep
is not None
.
Co-authored-by: Christian Mönch <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #548 +/- ##
==========================================
+ Coverage 83.65% 92.66% +9.00%
==========================================
Files 137 137
Lines 10035 10049 +14
Branches 1085 1086 +1
==========================================
+ Hits 8395 9312 +917
+ Misses 1632 713 -919
- Partials 8 24 +16 ☔ View full report in Codecov by Sentry. |
This commit fixes a bug in `decode_bytes` where an empty string was yielded as a result. A regression test was added as well. The bug was the reason for one of the errors created by `doctest-modules`
This commit adds a number of `+SKIP` flags to code examples in order to prevent their execution. The execution would fail since the example code lines are not generic tests.
Extracted and modified from #539
mypy
complains: