fix small issues in iter_subproc
#547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mih
commented
Nov 27, 2023
This commit fixes a small bug in `iter_subproc.__init__`. The parameter `chunksize` was never used. Instead a constant value was used. The new code passes the value down to `iterable_subprocess`.
This commit changes the type of the `input`-parameter of `iter_subproc` from `List[bytes]` to `Iterable[bytes]` (wich includes `List[bytes]`). The previous annotation was unnecessarily restrictive and would lead to type-check errors if an iterator-object, e.g. a result of `iter(...)` was provided as `input`-parameter.
christian-monch
force-pushed
the
bf-iter-subproc
branch
from
ddc6ada
to
9b3f3e8
Compare
|
Appveyor is not in a good place -- but that is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a small bug in
iter_subproc.__init__. The parameterchunksizewas never used. Instead a constant value was used. The new code passes the value down toiterable_subprocess.This commit also improve iter_subproc type
annotation for
inputto accept anyIterable.