Replace www-authenticate #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #495 +/- ##
==========================================
+ Coverage 92.39% 92.41% +0.02%
==========================================
Files 125 126 +1
Lines 9549 9577 +28
Branches 1028 1036 +8
==========================================
+ Hits 8823 8851 +28
Misses 704 704
Partials 22 22
☔ View full report in Codecov by Sentry. |
The implementation is built on request's parsing utilities rather than elusive regexes. I find this better to grasp. The associated test includes all www-authenticate test cases, plus a set of additional ones that focus on multi-challenge header specifications. Closes datalad#493
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the www-authenticate dependency with internal function
The implementation is built on request's parsing utilities rather than elusive regexes. I find this better to grasp.
The associated test includes all www-authenticate test cases, plus a set of additional ones that focus on multi-challenge header specifications.
Closes #493