Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch run() placeholder substitutions to honor configuration defaults #485

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

mih
Copy link
Member

@mih mih commented Oct 13, 2023

This is the companion of datalad/datalad#7509

Closes #478

@mih mih added the semver-patch PR implies patch-level version increment (API stable) label Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c64978b) 92.08% compared to head (5716843) 92.33%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #485      +/-   ##
==========================================
+ Coverage   92.08%   92.33%   +0.25%     
==========================================
  Files         123      125       +2     
  Lines        9109     9526     +417     
  Branches     1011     1025      +14     
==========================================
+ Hits         8388     8796     +408     
- Misses        704      708       +4     
- Partials       17       22       +5     
Files Coverage Δ
datalad_next/patches/enabled.py 100.00% <ø> (ø)
datalad_next/patches/run.py 100.00% <100.00%> (ø)
datalad_next/patches/tests/test_run.py 98.48% <94.11%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mih mih merged commit 226c293 into datalad:main Oct 15, 2023
7 of 8 checks passed
@mih mih deleted the patch-run branch October 15, 2023 18:32
@mih mih added this to the 1.0.1 milestone Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch PR implies patch-level version increment (API stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add patch for run substitutions
1 participant