-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace a few more uses of virtualenv with venv #446
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patches. Left a comment regarding python versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a brief comment: I think it would be more sensible to have this PR against the extension template. The load on the CI would be less, and it will need to be done there anyways.
worth doing there too but I guess it is not to be merged here anyways:
|
apparently needs still to be installed for Ubu20... will add here
|
Ref: datalad/datalad-next#446 and there on
ca95b0a
to
1e1aa07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate the enthusiasm. But all the energy here is spent on fixing something that is not broken.
I do pull in changes from the template.
Ref: datalad/datalad-next#446 and there on Conflicts: .appveyor.yml - we had more here
No description provided.