Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing and fix wrong docstrings for HTTP/WebDAV server related fixtures #445

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

adswa
Copy link
Member

@adswa adswa commented Sep 4, 2023

I noticed a few missing docstrings (http_credential, webdav_credential), typos, and copy-paste errors (http_server) in the docstrings of these fixtures. Here is a quick fix.
Fixes #444

@adswa adswa requested a review from mih as a code owner September 4, 2023 12:55
@adswa
Copy link
Member Author

adswa commented Sep 4, 2023

As these are only docstring changes, I've cancelled the Appveyor and CrippledFS runs.

Copy link
Contributor

@christian-monch christian-monch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks

@adswa
Copy link
Member Author

adswa commented Sep 12, 2023

thanks for the review, @christian-monch

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (cc40c93) 91.96% compared to head (b1de046) 91.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #445   +/-   ##
=======================================
  Coverage   91.96%   91.96%           
=======================================
  Files         122      122           
  Lines        9101     9101           
=======================================
  Hits         8370     8370           
  Misses        731      731           
Files Changed Coverage Δ
datalad_next/tests/fixtures.py 94.66% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@mih mih merged commit 50b0f28 into datalad:main Sep 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small issues with docstrings of HTTP/WebDAV server related fixtures
3 participants