Add tests for progress report on size-less http downloads #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
==========================================
+ Coverage 91.96% 92.17% +0.20%
==========================================
Files 122 122
Lines 9101 9107 +6
==========================================
+ Hits 8370 8394 +24
+ Misses 731 713 -18
☔ View full report in Codecov by Sentry. |
christian-monch
force-pushed
the
enh-tests-chunked-progress-report
branch
2 times, most recently
from
a7245f9
to
c496b84
Compare
|
This has been in draft mode for a long time. I know see that a review was requested (missed that due to the draft mode, sorry). I am closing this PR for now as part of a cleanup. Feel free to reopen when the conflicts are removed. Sorry for the hassle. |
This commit updates the comments in url_oerations/http.py to explain why and how we calculate downloaded bytes in the absence of a content-length header.
This commit adds a test that verifies that http-download progress is reported, if no content-length header is provided.
|
Thanks, conflicts removed and reopened |
christian-monch
force-pushed
the
enh-tests-chunked-progress-report
branch
from
c496b84
to
87040e1
Compare
mih
approved these changes
Oct 27, 2023
|
Sorry, no, only comments are adjusted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test to verify that http-download reports progress if no content-length is provided in the http-result headers. In addition the comments w.r.t. to download size calculation are updated to reflect the code.
This is a small add-on to #365 (which was already merged)