Replace memory_keyring with tmp_keyring
#264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The former was limited to within process operations. However, we do need to be able to communicate credentials to child processes, such as (special) remotes. The approach for the `tmp_keyring` fixture is to replace the storage file for the plaintext keyring with a random file, and then communicate the path via the DATALAD_TESTS_TMP_KEYRING_PATH envvar. An additional patch recognizes this variable and alters a keyring in a child process accordingly.
Much cleaner. Both in terms of style and in terms of actually isolating the side-effect of individual tests from each other. Requesting the `credman` fixture automatically implies global config isolation and keyring isolation.
The `credman` fixture is a superior approach.
Pytest docs recommend against importing them. Instead, they should be declared as plugins via something like ``` pytest_plugins = "datalad_next.tests.fixtures" ``` https://docs.pytest.org/en/latest/how-to/fixtures.html#using-fixtures-from-other-projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former was limited to within process operations. However, we do need to be able to communicate credentials to child processes, such as (special) remotes.
The approach for the
tmp_keyringfixture is to replace the storage file for the plaintext keyring with a random file, and then communicate the path via the DATALAD_TESTS_TMP_KEYRING_PATH envvar.An additional patch recognizes this variable and alters a keyring in a child process accordingly.