Make dataset-lookup behavior of credentials identical to download
#256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mih
force-pushed
the
explore-249
branch
11 times, most recently
from
7ebfe10
to
0b48cae
Compare
When called with `dataset=None`, `credentials()` would auto-locate a dataset containing CWD (and use its configuration), whereas `download()` would use the global configuration in this case. This change makes the behavior uniform and chooses what `download()` did as the model behavior. This uniformatization is meaningful on its own. However, due to datalad/datalad#7299 it is also a necessity, because otherwise credentials deposited by `download()` remain invisible to `credentials()` -- which is the superficial trigger for datalad#249 Closes datalad#249
mih
changed the title
credentials identical to download
|
Still failing in a myriad of way -- BUT NOT A SINGLE ONE IS #249 !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When called with
dataset=None,credentials()would auto-locatea dataset containing CWD (and use its configuration), whereas
download()would use the global configuration in this case.This change makes the behavior uniform and chooses what
download()did as the model behavior.
This uniformatization is meaningful on its own.
However, due to datalad/datalad#7299 it is
also a necessity, because otherwise credentials deposited by
download()remain invisible tocredentials()-- which is thesuperficial trigger for #249
Closes #249