RF of CredentialManager.get() related code
#252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only report on credentials that have a secret. Issue only a debug message on credential fragments without one. The recorded use case for the previous behavior was the discovery of credential fragments for clean-up. However, that was nohow properly implemented, and it seems cleaner to ignore random cruft than have it impose handling complexity on a CredentialManager user. Now `CredentialManager.get()` reports a credential that has a secret, or it does not report at all (i.e. None).
|
#249 still unresolved, the rest is good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to find what is happening with #249 by making the implemented logic less complex.