Fix TestTreeWithDatasets failure #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpoldrack
force-pushed
the
dbg-tree-failure
branch
2 times, most recently
from
35a74a0
to
55f471d
Compare
bpoldrack
changed the title
bpoldrack
force-pushed
the
dbg-tree-failure
branch
from
55f471d
to
e40a630
Compare
The order of execution of the former markup for the base class vs derived class somehow changed, leading to the base class' injection overwriting what the subclass already set for its `path`. Unsure whether that is depend on python or pytest version. In any case, that means a setup independent of that order is needed. Hence, instead of overwriting the `path` class attribute, have a fixture that dynamically decides based on a another, constant class attribute defining which kind of tree the test case wants.
Codecov ReportBase: 94.38% // Head: 91.11% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
- Coverage 94.38% 91.11% -3.27%
==========================================
Files 38 38
Lines 3955 4244 +289
==========================================
+ Hits 3733 3867 +134
- Misses 222 377 +155
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bpoldrack
force-pushed
the
dbg-tree-failure
branch
from
e40a630
to
2496e7b
Compare
bpoldrack
changed the title
mih
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to figure a test failure, we missed. Somehow a
treetest is picking up the wrong root path to run on. Noticed in core's extension test first, but reproduced here on appveyor.So, it turns out, that the fixture injection with the
TestTreeWithoutDatasetscase and the derived test caseTestTreeWithDatasetsstopped working as intended. The base class'inject_path_no_dsapparently is executed after the derived class'inject_path_ds, overwriting the root path for the test.Don't know for sure whether that's a change in python or pytest.
This patch switches the approach to have a shared fixture decide dynamically and only once, rather than overwriting each other.