Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish setup of type annotation workflow #501

Closed
mih opened this issue Oct 23, 2023 · 0 comments · Fixed by #510
Closed

Finish setup of type annotation workflow #501

mih opened this issue Oct 23, 2023 · 0 comments · Fixed by #510

Comments

@mih
Copy link
Member

mih commented Oct 23, 2023

There is already a draft at .github/workflows/mypy.yml, but as evident by the logs, it is not in a good state yet (dependencies missing etc.)
mih added a commit to mih/datalad-next that referenced this issue Oct 25, 2023
@mih
Type annotation check simplified and only scanning changes
7902a70 
The previous setup tried everything and produces an overwhelming report
that nobody would pay attention to. This new approach would selectively
report on content that is near that touch be a specific PR.

Closes datalad#501
@mih mih mentioned this issue Oct 25, 2023
Merged
mih added a commit to mih/datalad-next that referenced this issue Oct 25, 2023
@mih
Type annotation check simplified and only scanning changes
4f5d5f3 
The previous setup tried everything and produces an overwhelming report
that nobody would pay attention to. This new approach would selectively
report on content that is near that touch be a specific PR.

Closes datalad#501
@mih mih closed this as completed in #510 Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Type annotation check simplified and only scanning changes mih/datalad-next
1 participant
@mih