We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FileSystemItem.from_path()
link_target=False
It will call readlink unconditionally for any symlink.
readlink
The following patch should fix it. A corresponding test is TODO.
diff --git a/datalad_next/iter_collections/utils.py b/datalad_next/iter_collections/utils.py index 0f00a2e..91fcdc4 100644 --- a/datalad_next/iter_collections/utils.py +++ b/datalad_next/iter_collections/utils.py @@ -96,7 +96,7 @@ class FileSystemItem(PathBasedItem, TypedItem): uid=cstat.st_uid, gid=cstat.st_gid, ) - if ctype == FileSystemItemType.symlink: + if link_target and ctype == FileSystemItemType.symlink: # could be p.readlink() from PY3.9+ item.link_target = PurePath(os.readlink(path)) return item
The text was updated successfully, but these errors were encountered:
iter_gitworktree
FileSystemItem.from_path() now honors link_target=False
aacdf96
Closes datalad#462
4f70546
6727efc
Successfully merging a pull request may close this issue.
It will call
readlink
unconditionally for any symlink.The following patch should fix it. A corresponding test is TODO.
The text was updated successfully, but these errors were encountered: