BF: ignore broken derivatives #73
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that bids-standard/pybids#444 was merged/released
…s are non compliant
|
@yarikoptic it looks like d54ec42 is already in |
|
Ping @yarikoptic |
|
I am converting this to a draft until it is in a mergeable state again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I CPed #72 as well since otherwise couldn't install in a local venv for some reason. Most likely testing would fail probably for the same GitPython 3.x regressions as in #72 .
With this PR we will just not read derivative(s) metadata if reading them fails. Relevant issue in pybids is bids-standard/pybids#473 which would boil down to more targetted exceptions so in the future we would be able to avoid matching a str(exc).