Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various BIDS-related improvements #40

Merged
merged 5 commits into from
Sep 27, 2018
Merged

Various BIDS-related improvements #40

merged 5 commits into from
Sep 27, 2018

Conversation

mih
Copy link
Member

@mih mih commented Aug 4, 2018

@mih mih changed the title RF: Protect against PyBIDS pickiness, even when debugging (fixes gh-34) Various BIDS-related improvements Aug 4, 2018
Rational: we enable extractors manually and consciously, hence
it is OK to traverse a directory tree that was explicitly labeled
as "contains BIDS stuff".
E.g. 'n/a' gets converted by pandas to NaN.
@codecov-io
Copy link

codecov-io commented Sep 27, 2018

Codecov Report

Merging #40 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   89.14%   89.03%   -0.11%     
==========================================
  Files          19       19              
  Lines         921      930       +9     
==========================================
+ Hits          821      828       +7     
- Misses        100      102       +2
Impacted Files Coverage Δ
datalad_neuroimaging/tests/test_search.py 83.33% <ø> (ø) ⬆️
datalad_neuroimaging/tests/test_aggregation.py 94.44% <100%> (+0.32%) ⬆️
datalad_neuroimaging/extractors/bids.py 90.9% <100%> (-1.57%) ⬇️
datalad_neuroimaging/extractors/tests/test_bids.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03eb4af...b68a6f2. Read the comment docs.

@mih mih merged commit bf464a2 into datalad:master Sep 27, 2018
@mih mih deleted the enh-bids branch September 27, 2018 10:50
@mih mih mentioned this pull request Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants