Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: make compatible with pybids 0.6.4 #39

Merged
merged 2 commits into from
Jul 31, 2018

Conversation

yarikoptic
Copy link
Member

in 0.6 pybids

  • dropped installation schemes
  • broke API

may be https://github.com/INCF/pybids/pull/218/files would return installation
scheme to improve compatibility, but I guess we should no longer rely on
it anyways

in 0.6 pybids

- dropped installation schemes
- broke API

may be https://github.com/INCF/pybids/pull/218/files would return installation
scheme to improve compatibility, but I guess we should no longer rely on
it anyways
@codecov-io
Copy link

codecov-io commented Jul 28, 2018

Codecov Report

Merging #39 into master will decrease coverage by 0.06%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage    89.2%   89.14%   -0.07%     
==========================================
  Files          19       19              
  Lines         917      921       +4     
==========================================
+ Hits          818      821       +3     
- Misses         99      100       +1
Impacted Files Coverage Δ
datalad_neuroimaging/extractors/tests/test_bids.py 100% <ø> (ø) ⬆️
datalad_neuroimaging/extractors/bids.py 92.47% <80%> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2120de...8326fac. Read the comment docs.

now it is demanded by pybids (Since required by bids spec)
@yarikoptic
Copy link
Member Author

I think it does the right thing, so will merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants