Test against 3.9 not EOLed 3.8, fix typo, compatibility with recent pydicom 3.x #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarikoptic
changed the title
|
on mac - the same story with timing out/lengthy installation of git-annex as observed on yet to figure out what those are about |
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w datalad_neuroimaging",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
22.04 has 3.10
ATM it fails as pip install --upgrade pip Requirement already satisfied: pip in c:\python39-x64\lib\site-packages (23.2.1) Collecting pip Obtaining dependency information for pip from https://files.pythonhosted.org/packages/d4/55/90db48d85f7689ec6f81c0db0622d704306c5284850383c090e6c7195a5c/pip-24.2-py3-none-any.whl.metadata Downloading pip-24.2-py3-none-any.whl.metadata (3.6 kB) Downloading pip-24.2-py3-none-any.whl (1.8 MB) ---------------------------------------- 1.8/1.8 MB 10.5 MB/s eta 0:00:00 ERROR: To modify pip, please run the following command: C:\Python39-x64\python.exe -m pip install --upgrade pip [notice] A new release of pip is available: 23.2.1 -> 24.2 [notice] To update, run: python.exe -m pip install --upgrade pip Command exited with code 1
brew installation gets stuck/takes too long.
yarikoptic
force-pushed
the
bf-testing
branch
from
6988623
to
cdb0e25
Compare
|
also to get it clean we need to resolve gotchas due to new pydicom 3.0.0 changing how to handle DICOMDIRs which we simply skip.. |
|
on mac we got taking solution from https://github.com/datalad/datalad/pull/7649/files (I hate duplication!...) |
…ent on 2204. Mimicing setup in datasalad a bit
this would allow to avoid masking the error as happens now
E: Repository 'http://ppa.launchpad.net/rabbitmq/rabbitmq-erlang/ubuntu jammy InRelease' changed its 'Label' value from 'Latest (26.x) Erlang packages for Ubuntu and Debian' to 'Modern Erlang and Elixir packages for Ubuntu'
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #133 +/- ##
==========================================
- Coverage 89.16% 88.80% -0.36%
==========================================
Files 24 23 -1
Lines 1181 1170 -11
==========================================
- Hits 1053 1039 -14
- Misses 128 131 +3 ☔ View full report in Codecov by Sentry. |
yarikoptic
changed the title
|
codecov isn't happy but at least we got to green state -- let's proceed and even release (if still works ;) ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.