Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify minimum version of importlib-metadata and importlib-resources #406

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

christian-monch
Copy link
Collaborator

This PR specifies minimum versions for importlib-metadata and importlib-resources.

This commit specifies minimum versions for
`importlib-metadata` and `importlib-resources`.
This should fix an error on Windows with
python 3.9
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad855b8) 82.98% compared to head (20b9762) 83.02%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #406      +/-   ##
==========================================
+ Coverage   82.98%   83.02%   +0.03%     
==========================================
  Files          92       92              
  Lines        5036     5036              
==========================================
+ Hits         4179     4181       +2     
+ Misses        857      855       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christian-monch christian-monch changed the base branch from master to maint_0.4 January 17, 2024 11:11
@christian-monch christian-monch merged commit 0047a32 into maint_0.4 Jan 17, 2024
4 of 5 checks passed
@christian-monch christian-monch deleted the fix-windows-entry-points branch January 17, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants