Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand tabs #369

Merged
merged 2 commits into from
Apr 24, 2023
Merged

Expand tabs #369

merged 2 commits into from
Apr 24, 2023

Conversation

asmacdo
Copy link
Member

@asmacdo asmacdo commented Mar 22, 2023

Just fixing a minor annoyance :)

AFAIK you'd always want expandtab for python.

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.37 🎉

Comparison is base (fc20e5c) 86.42% compared to head (0e9bbfa) 86.79%.

❗ Current head 0e9bbfa differs from pull request most recent head 6df3075. Consider uploading reports for the commit 6df3075 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
+ Coverage   86.42%   86.79%   +0.37%     
==========================================
  Files          88       92       +4     
  Lines        4831     5020     +189     
==========================================
+ Hits         4175     4357     +182     
- Misses        656      663       +7     
Impacted Files Coverage Δ
datalad_metalad/add.py 91.91% <ø> (ø)
datalad_metalad/aggregate.py 80.53% <ø> (ø)
datalad_metalad/conduct.py 64.21% <ø> (ø)
datalad_metalad/dump.py 74.05% <ø> (ø)
datalad_metalad/extract.py 91.05% <ø> (ø)
datalad_metalad/extractors/annex.py 96.29% <ø> (ø)
datalad_metalad/extractors/base.py 88.00% <ø> (+1.33%) ⬆️
datalad_metalad/extractors/core.py 79.24% <ø> (ø)
datalad_metalad/extractors/custom.py 100.00% <ø> (ø)
datalad_metalad/extractors/external_dataset.py 100.00% <ø> (ø)
... and 16 more

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@christian-monch christian-monch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx a lot @asmacdo

@yarikoptic
Copy link
Member

Looks good @christian-monch -- let's merge?

@yarikoptic
Copy link
Member

let's do it, I hope not to step onanyone shoes

@yarikoptic yarikoptic merged commit 8ca406d into datalad:master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants