Adjust imports deprecated in next 1.0.0 and core 0.18 #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The eval_results function has been moved from interface.utils to interface.base in DataLad 0.18.0, and the previous usage is deprecated. See datalad/datalad#7170 or DataLad changelog.
|
Note: doc build error happens in GitHub CI but not in Read The Docs, and error message contains a solution which will be a one-liner update to config: https://www.sphinx-doc.org/en/master/usage/extensions/intersphinx.html#confval-intersphinx_mapping |
adswa
approved these changes
Jun 20, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #428 +/- ##
==========================================
+ Coverage 60.52% 60.54% +0.01%
==========================================
Files 49 49
Lines 3511 3505 -6
==========================================
- Hits 2125 2122 -3
+ Misses 1386 1383 -3 ☔ View full report in Codecov by Sentry. |
|
I've restarted the Appveyor test, and gave it a very quick try and test run locally, and everything seems to work nicely. I'll merge this. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes imports of
CredentialManager(from next) andeval_resultsto match their current locations. Closes #427