-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templates for using datalad/release-action #49
Conversation
Codecov ReportBase: 92.85% // Head: 92.85% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
=======================================
Coverage 92.85% 92.85%
=======================================
Files 5 5
Lines 42 42
=======================================
Hits 39 39
Misses 3 3 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@yarikoptic Ping. |
Looks good to me. @mih any suggestions/objections? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure what to add in the documentation re tailoring for a dedicated extension. I would have no idea what to do personally. We could move the files in .github
aside and turn them into a "template" or "sketch". Or add documentation on what they try to achieve. Either way is fine with me. Only the combination of active and no docs should be avoided. To clarify, I am mostly talking about the workflows. The changelog.d
is dead-weight for people who don't use scriv
, but it also does nothing in that case.
agree
not really -- scriv would be used by action, so it would be "editable metadata for the release action" even if they don't use @jwodder, please
|
@yarikoptic Note that DataLad's |
Refer to it how? What exactly should be said? |
in datalad we have
which sounds good to paste here.
oh ok, nevermind then... @bpoldrack soon will cut new major minor release so it would become up to date... if doesn't happen then we would bring it up again. |
ok, I think this PR is ready. Added it to tomorrow's meetup agenda to seek feedback/blessing |
This is reading an extension for using the release action, but does not impose its use. All good with me. Thx! |
Closes #48.