Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve doi and url handling #74

Merged
merged 9 commits into from
Jun 17, 2022
Merged

improve doi and url handling #74

merged 9 commits into from
Jun 17, 2022

Conversation

ksarink
Copy link
Collaborator

@ksarink ksarink commented Jun 17, 2022

add checks for doi and url config parameters
remove trainging slash in url
reformat doi string when necessary
lazy evaluting of annex config

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2022

Codecov Report

Merging #74 (c88db24) into main (668fc1f) will decrease coverage by 3.09%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   30.43%   27.34%   -3.10%     
==========================================
  Files           8        8              
  Lines         230      256      +26     
==========================================
  Hits           70       70              
- Misses        160      186      +26     
Impacted Files Coverage Δ
datalad_dataverse/remote.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 668fc1f...c88db24. Read the comment docs.

@ksarink ksarink marked this pull request as ready for review June 17, 2022 14:09
@ksarink ksarink requested a review from mih June 17, 2022 14:09
@ksarink
Copy link
Collaborator Author

ksarink commented Jun 17, 2022

Closes #52

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than missing tests, this is good. Thx!

@mih mih force-pushed the improve-config-handling branch from d580f55 to 77b56ba Compare June 17, 2022 14:44
@ksarink ksarink merged commit 3399915 into main Jun 17, 2022
@ksarink ksarink deleted the improve-config-handling branch June 17, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants