-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve doi and url handling #74
Conversation
Codecov Report
@@ Coverage Diff @@
## main #74 +/- ##
==========================================
- Coverage 30.43% 27.34% -3.10%
==========================================
Files 8 8
Lines 230 256 +26
==========================================
Hits 70 70
- Misses 160 186 +26
Continue to review full report at Codecov.
|
Closes #52 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than missing tests, this is good. Thx!
d580f55
to
77b56ba
Compare
add checks for doi and url config parameters
remove trainging slash in url
reformat doi string when necessary
lazy evaluting of annex config