Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-persistentId mode for data file retrieval #311

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

shoeffner
Copy link
Contributor

Closes #310.

As mentioned in #310, I am not sure if this is a good solution and am looking forward to your ideas on this one, hence I'll mark it as a draft for now.

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this is the right call. In may not be applicable to all scenarios, but for the purposes relevant here, we only work with the non-persistent file IDs.

@mih mih marked this pull request as ready for review July 19, 2024 13:08
@mih mih merged commit 8a55062 into datalad:main Jul 19, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datalad get fails with 404 due to :persistentId usage in pydataverse
2 participants