Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split export from non-export remote functionality #177

Closed
mih opened this issue Feb 28, 2023 · 2 comments · Fixed by #207
Closed

Split export from non-export remote functionality #177

mih opened this issue Feb 28, 2023 · 2 comments · Fixed by #207

Comments

@mih
Copy link
Member

mih commented Feb 28, 2023

Starting from #170 I waded through the special remote implementation. I cannot pinpoint it yet, but I believe ti is needlessly complex, because two different scenarios are supported by the same implementation. This imposes a needless complexity on consumers of the simple case.

Moreover, the current complexity imposed by the export functionality is not even delivering a sufficient set of functionality, because fundamental issues are unresolved (such as the file name mangling).

I thing the export-remote parts should be factored out, such that one can clearly see what is needed and what is an additional requirement for exporting.

This also includes the documentation: presently this is multiple pages of caveats. I sign that things are not in a good state yet.

@mih
Copy link
Member Author

mih commented Feb 28, 2023

#101 is another use case for supporting different use cases with different implementations

@mih
Copy link
Member Author

mih commented Mar 10, 2023

I have concluded my analysis on how datalad-dataverse should behave in non-export mode.

For export mode the situation is dire. Path mangling creates a situation that makes importtree unable to recreate a tree. #148 (comment) Moreover, implementing importtree is a fairly monumental development (across 2 or 3 packages). #146 (comment)

Given that, I think it would be sensible to clearly separate these two implementations, and also manage user-expectations properly

mih added a commit to mih/datalad-dataverse that referenced this issue Mar 10, 2023
@mih mih closed this as completed in #207 Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant