MNT: Account for a number of deprecations in core #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this reduces the number of deprecation warnings when running the test suite
|
Code Climate has analyzed commit 9fa80bd and detected 0 issues on this pull request. View more on Code Climate. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #268 +/- ##
==========================================
- Coverage 94.60% 94.60% -0.01%
==========================================
Files 24 24
Lines 1113 1112 -1
==========================================
- Hits 1053 1052 -1
Misses 60 60 ☔ View full report in Codecov by Sentry. |
yarikoptic
reviewed
Sep 16, 2024
| @@ -107,7 +107,7 @@ def test_container_files(ds_path=None, local_file=None, url=None): | |||
| # non-default location: | |||
| ds.config.add("datalad.containers.location", | |||
| value=op.join(".datalad", "test-environments"), | |||
| where='dataset') | |||
| scope='branch') | |||
There was a problem hiding this comment.
currently we have datalad > 0.18.0 and scope came in 0.16.0 . the other changes (drop and install) I think even before then so we should be good. Thank you @adswa !
yarikoptic
added
patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this reduces the number of deprecation warnings when running the test suite