WIN/BF: When on Windows, close temporary files for further use #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarikoptic
reviewed
Nov 10, 2020
datalad_container/adapters/docker.py
Outdated
| @@ -44,6 +48,9 @@ def save(image, path): | |||
| # Use a temporary file because docker save (or actually tar underneath) | |||
| # complains that stdout needs to be redirected if we use Popen and PIPE. | |||
| with tempfile.NamedTemporaryFile() as stream: | |||
| if on_windows: | |||
There was a problem hiding this comment.
do we really need to condition it with on_windows? sounds like it could just be generally done, or am I missing something?
There was a problem hiding this comment.
Oh, true. For some reason, I didn't think of this. Will adjust.
This adds a switch to explicitly close a temporary file created by tempfile.NamedTemporaryFile(). tempfile not only creates a file, but also opens it. While Unix system can write to a file that is opened by another process, current Windows versions can't, and further use of the temporary file in a subprocess results in Access Denied crashes. For context, see github.com/datalad/datalad/issues/5138
|
I've cancelled one of the dup Travis builds. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to put my explorations from datalad/datalad#5138 into a PR. Running tests locally on Windows is a potpourri of errors, so pushed this hoping that the CI catches everything that I might have broken with this for other operating systems ;-)