New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fine tuning of HTML rendering #347

Merged

jsheunis merged 2 commits into main from asset-updates

Sep 22, 2023

Member

jsheunis commented Sep 21, 2023

This PR:

hides fields, including properties, journal, and grant description, if they are not populated, to prevent empty properties from making the rendered page ugly
improves parsing of objects and arrays in the additional display tab so that they can be rendered in a more visually pleasing way.

Example 1:

New:

Screenshot 2023-09-21 at 22 52 03

vs old:

Example 2:

New:

vs old

Example 3:

New:

vs old:

jsheunis added 2 commits

September 21, 2023 21:57


          hide unpopulated fields, including properties, journal, and grant des…

b1963a6

…cription, on the dataset page


          improve rendering of objects and arrays in additional display tab

9a1ae7b

mslw approved these changes

View reviewed changes

Collaborator

mslw left a comment

I have not tried it in practice, but I really like the way the screenshots look, and the template changes seem reasonable.

jsheunis merged commit 75cd669 into main

6 checks passed

This was referenced Sep 22, 2023

Improve rendered dataset page sfb1451/tabby-utils#7

Closed

Accept and render JSON-LD metadata #341

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet