Fix datacite_gin publication doi translation #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now uses a case-insensitive replacement (accepting both "doi:" and "DOI:" prefix in translated metadata) and returns the DOI as https://doi.org/... (no www) because this is the format expected by the catalog for nice rendering.
This commit is a manual change to the expected doi value, replacing `doi:` with `https://doi.org/` in response to the change introduced in e925c3e. The updated values are consistent e.g. with the doi formatting in `workflow_generated_meta_super.json`.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
=======================================
Coverage 82.32% 82.32%
=======================================
Files 32 32
Lines 2173 2173
=======================================
Hits 1789 1789
Misses 384 384
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small tweak to
datacite_gin_translatorthat will:https://doi.org/...(no www) because this is the format expected by the catalog for nice renderingFMPOV this should be enough to close #322 as it answers the original problem -- unless you do want to add more formatting rules to JS.
Ping sfb1451/metadata-catalog#23