Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: URL parameterization #295

Merged
merged 2 commits into from
Apr 18, 2023
Merged

ENH: URL parameterization #295

merged 2 commits into from
Apr 18, 2023

Conversation

jsheunis
Copy link
Member

This PR addresses #293

Mainly:

  • it is now possible to specify the tab name (e.g. subdatasets, content, publications, etc) as a URL parameter and navigation will ensure that the corresponding tab is opened when opening the dataset page. If a corresponding tab does not exist, the first tab is opened (subdatasets; whether the dataset has subdatasets or not.)
  • if a dataset has no subdatasets or content, the next available tab will open when the page is viewed

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2a295a8) 82.32% compared to head (c7e8edf) 82.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   82.32%   82.32%           
=======================================
  Files          32       32           
  Lines        2173     2173           
=======================================
  Hits         1789     1789           
  Misses        384      384           
Flag Coverage Δ
unittests 71.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants