Bids translator - fix name & license reporting #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In BIDS 1.8.0 and earlier, dataset_description.json has "Name" and "License" keys, and both fields are strings. The bids_dataset extractor from datalad-neuroimaging (looking at current master) keeps these keys. The change also includes the license in the translated output.
Only covers "PDDL" and "CC0", the two licenses named explicitly with urls in the BIDS v1.8.0 spec. BIDS spec lists those as examples (alongside PD, which has no link), and anything else is possible, but at least we give the two a chance to get translated with a proper URL -- dataset_description.json only stores license name.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
==========================================
- Coverage 82.40% 82.32% -0.08%
==========================================
Files 32 32
Lines 2171 2173 +2
==========================================
Hits 1789 1789
- Misses 382 384 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Thanks @mslw looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In BIDS 1.8.0 and earlier, dataset_description.json has "Name" and "License" keys, and both fields are strings. The bids_dataset extractor from datalad-neuroimaging keeps these key names.
This PR fixes the field lookup, and also includes the license in the translated output.
The change also lets the extractor add license url for "PDDL" and "CC0" (the two are named explicitly in bids spec, others are allowed but at least we give the two a chance to get translated with a proper URL).