Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codespell: typo fixes, config, workflow #257

Merged
merged 9 commits into from
Mar 15, 2023

Conversation

yarikoptic
Copy link
Member

No description provided.

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "git-sedi datalad-atalog datalad-catalog",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "codespell -w",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@yarikoptic
Copy link
Member Author

oh, appveyor fails , seems a result of my fixups here -- was tricky to do them in those bigonelined json files.

        keys_to_test = [
            "authors",
            "children",
            "description",
            "funding",
            "keywords",
            "publications",
            "license",
            "name",
            "type",
        ]
>       assert_dict_values_equal(generated_meta, correct_meta, keys_to_test)
../datalad_catalog/tests/test_workflow.py:444: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
../datalad_catalog/tests/test_workflow.py:490: in assert_dict_values_equal
    assert_equal(dict_to_test[key], dict_correct[key])
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
first = '"Extension of the dataset published in Hanke et al.\n (2014; doi:10.1038/sdata.2014.3) with additional acquisitions f...-German CRCNS project,\n co-funded by the BMBF and the US National Science Foundation\n (BMBF 01GQ1411; NSF 1429999)."'
second = '"Extension of the dataset published in Hanke et al.\n (2014; doi:10.1038/sdata.2014.3) with additional acquisitions f...-German CRCNS project,\n co-funded by the BMBF and the US National Science Foundation\n (BMBF 01GQ1411; NSF 1429999)."'

will try tolook into it later unless @jsheunis beats me to it ;)

@yarikoptic
Copy link
Member Author

FWIW, allowed to fix typos in json and fixed them automagically - let's see if helps

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3c43207) 82.81% compared to head (c0a0fab) 82.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #257   +/-   ##
=======================================
  Coverage   82.81%   82.81%           
=======================================
  Files          32       32           
  Lines        2147     2147           
=======================================
  Hits         1778     1778           
  Misses        369      369           
Flag Coverage Δ
unittests 72.26% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datalad_catalog/_version.py 46.59% <ø> (ø)
datalad_catalog/catalog.py 80.11% <ø> (ø)
datalad_catalog/tests/test_workflow.py 89.05% <ø> (ø)
datalad_catalog/webcatalog.py 90.29% <ø> (ø)
datalad_catalog/tests/test_config.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jsheunis
Copy link
Member

Thanks @yarikoptic!

@jsheunis jsheunis merged commit ebe831f into datalad:main Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants