Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: don't install jq dependency on windows #248

Merged
merged 3 commits into from
Feb 21, 2023
Merged

ENH: don't install jq dependency on windows #248

merged 3 commits into from
Feb 21, 2023

Conversation

jsheunis
Copy link
Member

@jsheunis jsheunis commented Feb 8, 2023

jq building is failing on windows during appveyor testing.

  • Tried --ignore= and --ignore-glob= flags unsuccessfully in appveyour cmd calls.
  • Tried using git-bash unsuccessfully.

This PR ensures:

  • jq is not installed on windows (add below to setup.cfg)
install_requires
   jq;platform_system!='Windows'
  • that the workflows.py module and related test_workflow.py are not collected by pytest on windows (added conf.py with content below:)
import platform

if platform.system() == 'Windows':
    collect_ignore_glob = ["*workflow.py", "*workflows.py"]

@jsheunis jsheunis force-pushed the windows-jq branch 5 times, most recently from c680a01 to 6cd1620 Compare February 10, 2023 10:30
@jsheunis jsheunis force-pushed the windows-jq branch 2 times, most recently from 3f24f0b to 6be71ea Compare February 21, 2023 11:18
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2023

Codecov Report

Base: 82.47% // Head: 82.75% // Increases project coverage by +0.28% 🎉

Coverage data is based on head (601a6a5) compared to base (06623fb).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
+ Coverage   82.47%   82.75%   +0.28%     
==========================================
  Files          25       26       +1     
  Lines        1603     1606       +3     
==========================================
+ Hits         1322     1329       +7     
+ Misses        281      277       -4     
Flag Coverage Δ
unittests 69.25% <75.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
conftest.py 66.66% <66.66%> (ø)
datalad_catalog/tests/test_workflow.py 99.17% <100.00%> (+<0.01%) ⬆️
datalad_catalog/_version.py 46.59% <0.00%> (+1.59%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jsheunis
Copy link
Member Author

Closes #224

@jsheunis jsheunis mentioned this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants