Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 add boundary outside recorded data #52

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jerometerrier
Copy link

fix #51
Hello @alexbourret
Maybe the way tofix the issue is not the best.
Could you give me a feedback ?
I will adjust if necessary.
Thanks for your help

@alexbourret
Copy link
Contributor

Hi @jerometerrier ! Thank you for your contribution !
I made a few modifications in the way the call is made, because according to piwebapi specs the key for boundary type is syncTimeBoundaryType for interpolated data and boundaryType for recorded data.
Also, I have added the boundary type selector to the attribute search connector in retrieve data mode.
We currently don't have a full pi-system instance available for testing. So I have prepared a downloadable beta (v1.2.4-beta.1) for testing. Let me know if you can try it and confirm that the feature is working as expected.
Thank you for your PR and your help !

@jerometerrier
Copy link
Author

Hi @alexbourret,
First of all, thank you very much for your responsiveness. 👍
And yes, you are right about the boundary with the interpolated values.

I just tested it locally; the tests I conducted with my version are working with yours.
I’m not able to run all the non-regression tests, but for these parts, it seems to be okay.
Thank you again for your responsiveness! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] miss boundary_type when reading recorded data
2 participants