-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): switch to vite and vitest #9451
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriscollins3456
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
things are looking solid on my end. I pulled down and tested locally one more time and things are looking good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The performance gains seem to be pretty similar to a previous PR (#6586) - huge gains for the dev server, and about a 3x speedup for production builds.
Compatibility
REACT_APP_SOMETHING
env vars will workTo Dos:
Other changes
Dev notes
yarn generate
gets run too frequently. I'd also like to skip the yarnInstall step if the build is cacheable, but gradle doesn't really like that.dist
.miragejs
. We previously used that library to mock our backend for the first iteration of our cypress tests. At some point we migrated our cypress tests tosmoke-test
and now use a live datahub backend instead of a mocked one, so everything related to miragejs was now stale.vi
instead ofjest
, and small tweaks to the way modules get mocked (specifically around default module exports andimportActual
).Checklist