Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(json-schema): do not send invalid URLs #9417

Merged
merged 5 commits into from
Dec 12, 2023
Merged

fix(json-schema): do not send invalid URLs #9417

merged 5 commits into from
Dec 12, 2023

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 8, 2023
hsheth2
hsheth2 approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise looks good

metadata-ingestion/src/datahub/ingestion/source/schema/json_schema.py Outdated Show resolved Hide resolved
@anshbansal anshbansal merged commit abbc4cd into master Dec 12, 2023
53 checks passed
@anshbansal anshbansal deleted the ab-fix-invalid-urls branch December 12, 2023 11:56
Salman-Apptware pushed a commit to Salman-Apptware/datahub that referenced this pull request Dec 15, 2023
@anshbansal @Salman-Apptware
fix(json-schema): do not send invalid URLs (datahub-project#9417)
9222f88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @hsheth2