Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(ingest): Bump avro pin: security vulnerability #9042

Merged
merged 7 commits into from
Oct 25, 2023
Merged

build(ingest): Bump avro pin: security vulnerability #9042

merged 7 commits into from
Oct 25, 2023

Conversation

asikowitz
Copy link
Collaborator

Unit tests looked good locally

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 18, 2023
@asikowitz
Copy link
Collaborator Author

Ran tests but not lint :|

@hsheth2
Copy link
Collaborator

hsheth2 commented Oct 18, 2023

@asikowitz looks like it's running into issues with the avro schema translation

@asikowitz
Copy link
Collaborator Author

The avro library added type annotations lol, I think that's it

@asikowitz asikowitz changed the title build(ingest): Unpin avro: security vulnerability build(ingest): Bump avro pin: security vulnerability Oct 18, 2023
hsheth2
hsheth2 approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once ci passes

@asikowitz
Copy link
Collaborator Author

@hsheth2 I added # mypy: ignore errors to the top of _schema_classes.py to pass CI. Please confirm this sounds reasonable to you

@asikowitz asikowitz merged commit 8a80e85 into datahub-project:master Oct 25, 2023
53 of 54 checks passed
@asikowitz asikowitz deleted the bump-avro branch October 25, 2023 17:06
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 26, 2023
@hsheth2 hsheth2 mentioned this pull request Oct 27, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asikowitz @hsheth2 @maggiehays