fix(ingest/sqlalchemy): Fix URL parsing when sqlalchemy_uri provided #9032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
treff7es
approved these changes
Oct 17, 2023
| f"{key}={quote_plus(value)}" for (key, value) in uri_opts.items() if value | ||
| host, port = at.rsplit(":", 1) | ||
| return str( | ||
| URL.create( |
maggiehays
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would not alter
sqlalchemy_urieven when trying to access a different database, resulting in errors. Since we provide this option we should support.I replace our custom
make_sqlalchemy_uriwith one provided by the sqlalchemy sdk. I have to parse host and port out ofatbut still think this is preferred. This method can handle multiple values for the same key, for example.Checklist