fix(ingest) - Fix file backed collection temp directory removal #9027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
asikowitz
approved these changes
Oct 17, 2023
maggiehays
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows the File Backed Collection's close failed when it tried to remove the temporary director it was created because the files were open.
This only caused issues on Windows because on Linux you can delete opened files while on windows you cannot.
The files were open because TemporayDirectory's close got called earlier than it should.
In my fix I got rid of TemporaryDirectory and handled temporary directory removal manually (which actually we did as well in the code). (Unfortunately with TemporayDirectory you can't control temp directory removal (you can only in Python 3.12)
Checklist