-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(boot): increases wait timeout for servlets initialization #8947
Merged
RyanHolstien
merged 5 commits into
datahub-project:master
from
PatrickfBraz:refactor/metadata-boot
Oct 5, 2023
Merged
refactor(boot): increases wait timeout for servlets initialization #8947
RyanHolstien
merged 5 commits into
datahub-project:master
from
PatrickfBraz:refactor/metadata-boot
Oct 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: I did not set this variable as configured via the environment. However, if necessary, I will make changes. |
github-actions
bot
added
the
devops
PR or Issue related to DataHub backend & deployment
label
Oct 4, 2023
maggiehays
added
the
community-contribution
PR or Issue raised by member(s) of DataHub Community
label
Oct 4, 2023
RyanHolstien
reviewed
Oct 4, 2023
...ta-service/factories/src/main/java/com/linkedin/metadata/boot/OnBootApplicationListener.java
Outdated
Show resolved
Hide resolved
Now I added the possibility of being configured via environment variable. @RyanHolstien |
RyanHolstien
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will merge once CI is green 😄 thanks!
maggiehays
added
the
hacktoberfest-accepted
Acceptance for hacktoberfest https://hacktoberfest.com/participation/
label
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community-contribution
PR or Issue raised by member(s) of DataHub Community
devops
PR or Issue related to DataHub backend & deployment
hacktoberfest-accepted
Acceptance for hacktoberfest https://hacktoberfest.com/participation/
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Typically in my deployment environment, servlets take anywhere from 20 seconds to 40 seconds to start. Because of this, in addition to the fact that I use more than one GMS replica, at times not all pods start correctly, resulting in the failure to deploy the Helm package to the Kubernetes cluster. Therefore, increasing the servlet initialization timeout can solve this problem for other developers who may experience the same problems.
Logs example:
NOTE: Sometimes the initialization fails even before the
schemaRegistryServlet
starts.Tests
Currently, my production environment already has this change and is working perfectly.
Checklist