fix(airflow): fix provider loading exception #8861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would previously see this from the plugin manager. ``` Exception: The package 'acryl-datahub' from setuptools and acryl-datahub-airflow-plugin do not match. Please make sure they are aligned ``` Also fixes + registers hook types
github-actions
bot
added
the
ingestion
5 tasks
asikowitz
approved these changes
Sep 20, 2023
Comment on lines
+83
to
+84
| "airflow.plugins": "acryl-datahub-airflow-plugin = datahub_airflow_plugin.datahub_plugin:DatahubPlugin", | ||
| "apache_airflow_provider": ["provider_info=datahub_provider:get_provider_info"], |
There was a problem hiding this comment.
Just curious, what are each of these entrypoints doing?
There was a problem hiding this comment.
the airflow.plugins one lets airflow load our plugin without any other config
the provider one lets it discover our hooks and display a nice UI in the add connection section
|
Merging through unrelated cypress failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would previously see this from the plugin manager.
Also fixes + registers hook types for new Airflow versions.
Checklist