feat(search): add filter for specific entities #7919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iprentic
requested review from
RyanHolstien,
chriscollins3456 and
david-leifker
metadata-io/src/main/java/com/linkedin/metadata/search/elasticsearch/query/ESSearchDAO.java
Show resolved
Hide resolved
metadata-io/src/main/java/com/linkedin/metadata/search/elasticsearch/query/ESSearchDAO.java
Outdated
Show resolved
Hide resolved
| * @param indexConvention The index convention used to generate the index name for an entity | ||
| * @return A filter, with the changes if necessary | ||
| */ | ||
| static Filter transformFilterForEntities(Filter filter, @Nonnull IndexConvention indexConvention) { |
There was a problem hiding this comment.
Why does this need to be static? Without it being static you don't need to pass in the indexConvention method param
There was a problem hiding this comment.
Doesn't need to be, but it seemed easier to test this way...
There was a problem hiding this comment.
Got it, yeah you can just new up the ESSearchDAO like is done here: https://github.com/datahub-project/datahub/blob/master/metadata-io/src/test/java/com/linkedin/metadata/ESSampleDataFixture.java#L99
(or convert this to a bean definition and wire it in instead of just the IndexConvention)
RyanHolstien
approved these changes
Apr 28, 2023
david-leifker
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist