Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ingest/biz-glossary): simplify business glossary source #7912

Merged
merged 9 commits into from
May 4, 2023
Merged

refactor(ingest/biz-glossary): simplify business glossary source #7912

merged 9 commits into from
May 4, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Apr 27, 2023

  • Add status aspects
  • Avoid global variables
  • Materialize urns up front

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Apr 27, 2023
@hsheth2 hsheth2 mentioned this pull request Apr 28, 2023
Closed
5 tasks
asikowitz
asikowitz reviewed May 2, 2023
View reviewed changes
Copy link
Collaborator

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can give a deeper review if necessary but I really have no clue what I'm reading. Someone more familiar with this source should probably review instead

metadata-ingestion/src/datahub/ingestion/source/looker/looker_common.py Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/metadata/business_glossary.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/confluent_schema_registry.py Outdated Show resolved Hide resolved
asikowitz
asikowitz approved these changes May 3, 2023
View reviewed changes
Copy link
Collaborator

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion but LGTM

metadata-ingestion/src/datahub/ingestion/source/metadata/business_glossary.py
Comment on lines +519 to +520
materialize_all_node_urns(glossary_config, self.config.enable_auto_id)
path_vs_id = populate_path_vs_id(glossary_config)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do these two together? The recursion looks the same and it seems like after the urns are calculated we can just alter path_vs_id after we define the urn

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use them separately here https://github.com/acryldata/business-glossary-sync-action/blob/main/glossary-sync.py#L473, which is why I structured it this way

@hsheth2 hsheth2 merged commit ca5dffa into datahub-project:master May 4, 2023
@hsheth2 hsheth2 deleted the glossary-updates branch May 4, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asikowitz asikowitz asikowitz approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @asikowitz