fix(ingest/unity): use fully qualified catalog/schema patterns #7900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
asikowitz
approved these changes
Apr 26, 2023
| @@ -138,7 +138,7 @@ export const UNITY_TABLE_ALLOW: RecipeField = { | |||
|
|
|||
| const tableDenyFieldPath = 'source.config.metastore_id_pattern.deny'; | |||
| export const UNITY_TABLE_DENY: RecipeField = { | |||
| name: 'catalog_pattern.allow', | |||
| name: 'table_pattern.allow', | |||
There was a problem hiding this comment.
Should this be table_pattern.deny? Also, do we need to change the field path?. Same goes for tableAllowFieldPath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our logs, we already display the fully qualified names for catalogs/schemas whenever we drop something. This changes the actual patterns to use the things that it's already printing out, and hence yields more explainable behavior.
This also updates some stuff in the UI ingestion form which just filled the wrong values into certain fields.
Closes #7489.
Checklist