Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): print detailed GMS error messages #6519

Merged
merged 6 commits into from
Dec 2, 2022
Merged

feat(ingest): print detailed GMS error messages #6519

merged 6 commits into from
Dec 2, 2022

Conversation

djordje-mijatovic
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 22, 2022
@github-actions
Copy link

github-actions bot commented Nov 22, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files         8 suites   1h 0m 28s ⏱️
   765 tests    763 ✔️ 2 💤 0 ❌
1 532 runs  1 527 ✔️ 5 💤 0 ❌

Results for commit 0afc977.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 22, 2022 •
edited
Loading

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   15m 36s ⏱️ -12s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit 0afc977. ± Comparison against base commit 7e326b7.

♻️ This comment has been updated with latest results.

hsheth2
hsheth2 approved these changes Dec 2, 2022
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed up the error handling a bit but LGTM

@hsheth2 hsheth2 changed the title Print validation errors in the python cli feat(ingest): print detailed GMS error messages Dec 2, 2022
@hsheth2 hsheth2 merged commit 99e6f3a into datahub-project:master Dec 2, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@djordje-mijatovic @hsheth2 @cccs-Dustin
feat(ingest): print detailed GMS error messages (datahub-project#6519)
5ec090e 
Co-authored-by: Harshal Sheth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 left review comments

@hsheth2 hsheth2 hsheth2 approved these changes

@szalai1 szalai1 szalai1 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djordje-mijatovic @szalai1 @hsheth2 @jjoyce0510