Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(loggin): print logging timestamp in ISO8601 format instead of jus… #6474

Merged
merged 2 commits into from
Nov 17, 2022
Merged

fix(loggin): print logging timestamp in ISO8601 format instead of jus… #6474

merged 2 commits into from
Nov 17, 2022

Conversation

szalai1
Copy link
Contributor

@szalai1 szalai1 commented Nov 17, 2022

…t time

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Nov 17, 2022
@szalai1 szalai1 added the devops PR or Issue related to DataHub backend & deployment label Nov 17, 2022
pedro93
pedro93 approved these changes Nov 17, 2022
View reviewed changes
Copy link
Collaborator

@pedro93 pedro93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please ensure CI is passing before merging.

@github-actions
Copy link

Unit Test Results (build & test)

622 tests  ±0   618 ✔️ ±0   15m 55s ⏱️ -13s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit f8de114. ± Comparison against base commit d3174e7.

@szalai1 szalai1 merged commit dc73987 into datahub-project:master Nov 17, 2022
@szalai1 szalai1 deleted the log-format branch November 17, 2022 11:34
@anshbansal anshbansal mentioned this pull request Jan 31, 2023
Merged
5 tasks
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@szalai1 @cccs-Dustin
fix(loggin): print logging timestamp in ISO8601 format instead of jus…
20d6318 
…t time (datahub-project#6474)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedro93 pedro93 pedro93 approved these changes

@jjoyce0510 jjoyce0510 Awaiting requested review from jjoyce0510

@david-leifker david-leifker Awaiting requested review from david-leifker

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szalai1 @pedro93