Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): init dataset props if missing in transformer #6429

Merged
merged 1 commit into from
Nov 14, 2022
Merged

fix(ingest): init dataset props if missing in transformer #6429

merged 1 commit into from
Nov 14, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Nov 14, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 14, 2022
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   56m 36s ⏱️ - 2m 42s
   758 tests ±0     755 ✔️ ±0  3 💤 ±0  0 ❌ ±0 
1 518 runs  ±0  1 511 ✔️ ±0  7 💤 ±0  0 ❌ ±0 

Results for commit c03abd6. ± Comparison against base commit 198c86a.

@github-actions
Copy link

Unit Test Results (build & test)

613 tests  +613   609 ✔️ +609   11m 46s ⏱️ + 11m 46s
151 suites +151       4 💤 +    4 
151 files   +151       0 ❌ ±    0 

Results for commit c03abd6. ± Comparison against base commit 198c86a.

@hsheth2 hsheth2 merged commit f75bb47 into datahub-project:master Nov 14, 2022
@hsheth2 hsheth2 deleted the init-dataset-props branch November 14, 2022 20:36
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@hsheth2 @cccs-Dustin
fix(ingest): init dataset props if missing in transformer (datahub-pr…
3538e9a 
…oject#6429)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabe-lyons gabe-lyons gabe-lyons approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @gabe-lyons