-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AWS Postgres Iam Auth jar to GMS #6371
Merged
RyanHolstien
merged 9 commits into
datahub-project:master
from
syedzoherer:iam_auth_postgres
Dec 5, 2022
Merged
Add AWS Postgres Iam Auth jar to GMS #6371
RyanHolstien
merged 9 commits into
datahub-project:master
from
syedzoherer:iam_auth_postgres
Dec 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanHolstien
requested changes
Nov 14, 2022
metadata-service/war/build.gradle
Outdated
@@ -25,6 +25,7 @@ dependencies { | |||
runtime spec.product.pegasus.restliSpringBridge | |||
|
|||
implementation externalDependency.awsMskIamAuth | |||
implementation externalDependency.awsPostgresIamAuth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you include some documentation on how to configure the usage of this wrapper?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed new changes and updated comments.
maggiehays
added
the
community-contribution
PR or Issue raised by member(s) of DataHub Community
label
Nov 14, 2022
RyanHolstien
approved these changes
Dec 5, 2022
cccs-Dustin
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Feb 1, 2023
* Add AWS Postgres Iam Auth jar to GMS * Added IAM support for Postgres * Setting IAM support for Postgres as false by default * format fix Co-authored-by: syed.javed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added changes to allow users to use IAM auth for AWS postgres. Follow below steps to enable IAM auth in datahub.
1-Enable IAM auth by uncommenting property "EBEAN_POSTGRES_USE_AWS_IAM_AUTH". When using Postgres IAM auth you do not need password, replace password with some dummy value.
2-When using IAM auth for postgres you will need to prefix your connection string with "jdbc:aws-wrapper". This is because AWS JDBC Driver uses the protocol prefix jdbc:aws-wrapper:.
Sample connection string when using IAM auth “jdbc:aws-wrapper:postgresql://{host}:5432/datahub”
3- Grant IAM access to user in rds - "GRANT rds_iam TO iamuser;"
[ X] The PR conforms to DataHub's [Contributing Guideline]