Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS Postgres Iam Auth jar to GMS #6371

Merged
merged 9 commits into from
Dec 5, 2022

Conversation

syedzoherer
Copy link
Contributor

@syedzoherer syedzoherer commented Nov 5, 2022

Added changes to allow users to use IAM auth for AWS postgres. Follow below steps to enable IAM auth in datahub.

1-Enable IAM auth by uncommenting property "EBEAN_POSTGRES_USE_AWS_IAM_AUTH". When using Postgres IAM auth you do not need password, replace password with some dummy value.

2-When using IAM auth for postgres you will need to prefix your connection string with "jdbc:aws-wrapper". This is because AWS JDBC Driver uses the protocol prefix jdbc:aws-wrapper:.

Sample connection string when using IAM auth “jdbc:aws-wrapper:postgresql://{host}:5432/datahub”

3- Grant IAM access to user in rds - "GRANT rds_iam TO iamuser;"

[ X] The PR conforms to DataHub's [Contributing Guideline]

@github-actions
Copy link

github-actions bot commented Nov 14, 2022

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   15m 44s ⏱️ -13s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ±0 

Results for commit 05966d7d. ± Comparison against base commit 329ecb8.

♻️ This comment has been updated with latest results.

@@ -25,6 +25,7 @@ dependencies {
runtime spec.product.pegasus.restliSpringBridge

implementation externalDependency.awsMskIamAuth
implementation externalDependency.awsPostgresIamAuth
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you include some documentation on how to configure the usage of this wrapper?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed new changes and updated comments.

@maggiehays maggiehays added the community-contribution PR or Issue raised by member(s) of DataHub Community label Nov 14, 2022
@RyanHolstien RyanHolstien merged commit ffea930 into datahub-project:master Dec 5, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
* Add AWS Postgres Iam Auth jar to GMS

* Added IAM support for Postgres

* Setting IAM support for Postgres as false by default

* format fix

Co-authored-by: syed.javed <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants