Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): allow specific profiler config fields to override profile_table_level_only #6366

Merged
merged 6 commits into from
Nov 16, 2022
Merged

feat(ingest): allow specific profiler config fields to override profile_table_level_only #6366

merged 6 commits into from
Nov 16, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Nov 4, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 4, 2022
@github-actions
Copy link

github-actions bot commented Nov 4, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files         8 suites   57m 3s ⏱️
   758 tests    755 ✔️ 3 💤 0 ❌
1 518 runs  1 511 ✔️ 7 💤 0 ❌

Results for commit 6dea3b6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 4, 2022 •
edited
Loading

Unit Test Results (build & test)

613 tests  ±0   609 ✔️ ±0   11m 51s ⏱️ -21s
151 suites ±0       4 💤 ±0 
151 files   ±0       0 ❌ ±0 

Results for commit 6dea3b6. ± Comparison against base commit 6e415ca.

♻️ This comment has been updated with latest results.

treff7es
treff7es approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

treff7es
treff7es reviewed Nov 16, 2022
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/ge_profiling_config.py
return any(
getattr(self, field_name)
for field_name in self.__fields__
if field_name.startswith("include_field_")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe later on, it would make sense to have these as constants as it is less prone to typos and easier to refactor if needed.

@treff7es treff7es merged commit 8c322ed into datahub-project:master Nov 16, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@hsheth2 @cccs-Dustin
feat(ingest): allow specific profiler config fields to override profi…
f03a629 
…le_table_level_only (datahub-project#6366)
@asikowitz asikowitz deleted the profiler-allow-specific-override branch June 28, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @treff7es