Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest): enable container stateful ingestion #6343

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

wangsaisai
Copy link
Contributor

@wangsaisai wangsaisai commented Nov 2, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 2, 2022
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the contribution

Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangsaisai please, can you run black formatting on sql_common.py?
It seems our formatting change fails.

@wangsaisai
Copy link
Contributor Author

@treff7es after black formatting sql_common.py, will modify codes contribute by others. Just format my owner code or format total file?

@treff7es
Copy link
Contributor

treff7es commented Nov 4, 2022

@treff7es after black formatting sql_common.py, will modify codes contribute by others. Just format my owner code or format total file?

Black formatting is a requirement for every pr, so the black formatting on the file would only change your code.

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   56m 56s ⏱️ + 1m 37s
   756 tests ±0     753 ✔️ ±0  3 💤 ±0  0 ±0 
1 514 runs  ±0  1 507 ✔️ ±0  7 💤 ±0  0 ±0 

Results for commit d27ce94. ± Comparison against base commit 3080b9e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Unit Test Results (build & test)

613 tests  ±0   609 ✔️ ±0   12m 34s ⏱️ +54s
151 suites ±0       4 💤 ±0 
151 files   ±0       0 ±0 

Results for commit d27ce94. ± Comparison against base commit 3080b9e.

@wangsaisai
Copy link
Contributor Author

@treff7es please help review again. Thanks

Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the contribution!

@treff7es treff7es merged commit 92192d2 into datahub-project:master Nov 8, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants