Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow links without top level domain #6317

Merged
merged 2 commits into from
Nov 3, 2022
Merged

Allow links without top level domain #6317

merged 2 commits into from
Nov 3, 2022

Conversation

djordje-mijatovic
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

It was already possible to add links without top domain directly but not via UI caused by validation. The validation level is updated from Error to Warning.

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Oct 31, 2022
@github-actions
Copy link

Unit Test Results (build & test)

599 tests  ±0   595 ✔️ ±0   11m 44s ⏱️ -19s
149 suites ±0       4 💤 ±0 
149 files   ±0       0 ❌ ±0 

Results for commit 4c2e1a8f. ± Comparison against base commit 0dc2d6a.

jjoyce0510
jjoyce0510 approved these changes Nov 3, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks guys

@jjoyce0510 jjoyce0510 merged commit ff885f0 into datahub-project:master Nov 3, 2022
anthonyhungnguyen pushed a commit to anthonyhungnguyen/zlp-datahub that referenced this pull request Nov 8, 2022
@djordje-mijatovic
refactor(ui): Enable url without mail domain (datahub-project#6317)
3392575
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@djordje-mijatovic @cccs-tom
refactor(ui): Enable url without mail domain (datahub-project#6317)
f278216
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@djordje-mijatovic @cccs-tom
refactor(ui): Enable url without mail domain (datahub-project#6317)
0c04131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

@chriscollins3456 chriscollins3456 Awaiting requested review from chriscollins3456

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djordje-mijatovic @jjoyce0510